Build system improvements for lto #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
bc7ed47 to
d8ee835
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
d8ee835 to
ef1bbb4
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
ef1bbb4 to
8912124
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
8912124 to
f8a94d4
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
f8a94d4 to
05ef6b3
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
05ef6b3 to
05a8744
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
2 times, most recently
from
15a734e to
c7a34c1
Compare
|
@swift-ci Please python lint |
|
@swift-ci Please smoke test |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
c7a34c1 to
02c8623
Compare
|
@swift-ci Please python lint |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
02c8623 to
59f0eff
Compare
|
@swift-ci please python lint |
|
@swift-ci Please smoke test linux |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
59f0eff to
a31c11f
Compare
|
@swift-ci Please smoke test linux |
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
a31c11f to
8e9d458
Compare
|
@swift-ci Please smoke test linux |
…s the triggering of ltoing llvm/swift tools. Also change the relevant build-presets to use this flag instead of touching build-script-impl directly. rdar://24717107
…M_PARALLEL_LINK_JOBS to swift as well as llvm. The reason to do this is the same reason that we already pass in -DLLVM_ENABLE_LTO=YES to swift, to ensure that parts of our codebase that use the llvm build machinery (e.g. the unittests) do not use too many linker jobs given the memory constraints of a given machine. rdar://24717107
This makes it clear to the user that they are enabling lto only for swift tools, not for the swift standard library/runtime. rdar://24717107
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
8e9d458 to
4aaea93
Compare
|
@swift-ci Please python lint |
gottesmm
changed the title
|
@swift-ci Please smoke test and merge |
…m build-script-impl into build support. rdar://24717107
gottesmm
force-pushed
the
build-system-improvements-for-lto
branch
from
4aaea93 to
2e7d88e
Compare
|
I fixed the smoke test failure issue on a linux machine. I feel ok merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.