ClangImporter: Reconcile Clang declaration hidden-ness between loadAllMembers() and lazy loading #29418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
commented
Jan 24, 2020
| @@ -8670,7 +8670,8 @@ void ClangImporter::Implementation::collectMembersToAdd( | |||
| for (const clang::Decl *m : objcContainer->decls()) { | |||
| auto nd = dyn_cast<clang::NamedDecl>(m); | |||
| if (nd && nd == nd->getCanonicalDecl() && | |||
| nd->getDeclContext() == objcContainer) | |||
| nd->getDeclContext() == objcContainer && | |||
| isVisibleClangEntry(nd)) | |||
There was a problem hiding this comment.
@DougGregor This is the relevant part of the change...
There was a problem hiding this comment.
Ah, looks totally reasonable!
|
Build failed |
|
Build failed |
slavapestov
force-pushed
the
lazy-member-loading-inconsistency
branch
from
7bc8d75 to
b6a488f
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
…lMembers() and lazy loading Lazy loading checked if the ClangDecl was hidden, but loading all members did not. Let's make loadAllMembers() behave like the lazy path, and fix some of the mock SDKs in the test suite.
slavapestov
force-pushed
the
lazy-member-loading-inconsistency
branch
from
b6a488f to
305620b
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading checked if the ClangDecl was hidden, but loading all
members did not. Let's make loadAllMembers() behave like the lazy
path, and fix some of the mock SDKs in the test suite.