Skip to content

Make -sil-print-only-function take comma separated values #29433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Jan 24, 2020

With this, something like -sil-print-only=function='foo','bar' can be handled.

@meg-gupta
Copy link
Contributor Author

I was debugging an issue where I needed to see the SIL of 2 functions and the ordering of the passes mattered. So I extended the meaning of the flag for comma separated list as well.

@meg-gupta meg-gupta requested a review from atrick January 24, 2020 19:54
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@meg-gupta
Copy link
Contributor Author

@swift-ci please smoke test

@meg-gupta
Copy link
Contributor Author

@swift-ci Please clean smoke test Linux platform

@meg-gupta meg-gupta merged commit ef7ddda into swiftlang:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants