[Build System: build-script] Remove the tar module from swift_build_support. #29468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport. The single function it provided to archive a source diretory has been moved to build-script which was the only caller.
|
@swift-ci please smoke test |
compnerd
approved these changes
Jan 27, 2020
|
@compnerd I just wanted to remove this unnecessary module while I'm transitioning the important functionality from |
Rostepher
commented
Jan 27, 2020
| 'destination' path. | ||
| """ | ||
| # We do not use `tarfile` here because: | ||
| # - We wish to support LZMA2 compression while also supporting Python 2.7. |
There was a problem hiding this comment.
Pretty sure we've never used this for LZMA2 compression, thus we should just use the builtin tarfile library. I'll do that in a follow-up PR.
There was a problem hiding this comment.
The builtin tarfile module supports lzma as well I think
There was a problem hiding this comment.
Only for Python 3.2 (or 3.3) and beyond. Python 2.7 supports gzip however, which appears to be all we use for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single function it provided to archive a source diretory has been moved to build-script which was the only caller.