[5.2][SILProfiler] Do not set up a profiler for a function twice #29482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://58861159
vedantk
changed the title
|
@swift-ci test |
|
LGTM. |
|
@jckarter thanks! @swift-ci nominate |
devincoughlin
approved these changes
Jan 28, 2020
vedantk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #29478 which addresses a crash in swift's code coverage logic (https://bugs.swift.org/browse/SR-12045): 'Assertion failed: Function already has a profiler'.
setUpForProfilingshould always have ignored functions which were already set up, so the issue has been present for a while. However, it's possible that after this function was introduced, SILGen was restructured in a way that makes it more likely to hit this code path.rdar://58861159