Move swift runtime failure messages from linkage name to function name #29506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
Build failed |
| @@ -1864,7 +1864,7 @@ void IRGenDebugInfoImpl::addFailureMessageToCurrentLoc(IRBuilder &Builder, | |||
| FuncName += failureMsg; | |||
|
|
|||
| llvm::DISubprogram *TrapSP = DBuilder.createFunction( | |||
| MainModule, StringRef(), FuncName, TrapLoc->getFile(), 0, DIFnTy, 0, | |||
| MainModule, FuncName, StringRef(), TrapLoc->getFile(), 0, DIFnTy, 0, | |||
| llvm::DINode::FlagArtificial, llvm::DISubprogram::SPFlagDefinition, | |||
There was a problem hiding this comment.
Can you please also add a testcase to test/DebugInfo ?
There was a problem hiding this comment.
I updated the original tests (test/DebugInfo/linetable-codeview.swift & test/IRGen/condfail_message.swift) to reflect my changes.
Should I add another test ?
There was a problem hiding this comment.
No, that is fine! For some reason I didn't see this earlier.
Signed-off-by: Med Ismail Bennani <[email protected]>
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves swift runtimes failure (#25978) messages from the linkage name to the function name.
Since the failure message (i.e.
Swift runtime failure: arithmetic overflow) don't conform with a proper mangling, when lldb tries to fetch the inlined frame symbol, it gets discarded. Moving it to the function name fixes this issue.Signed-off-by: Med Ismail Bennani [email protected]