[5.2] SILGen: Lower the type of the return value merge phi in the context of the current function #29509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text of the current function * Description: The lowering of return block arguments did not lower opaque result types in the context of the function. This leads to SIL verification errors in assert builds. * Scope: Introduced with the automatic lowering of opaque result types to their underlying types based on the current function context last year. * Testing: A regression test was added to the Swift test suite. rdar://58929484
|
@swift-ci Please test |
|
Original PR: #29508 |
tkremenek
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opaque result types in the context of the function. This leads to SIL
verification errors in assert builds.
to their underlying types based on the current function context last year.
rdar://58929484