[ClangImporter] Redeclarations as Refinements #29561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
CodaFi
force-pushed
the
an-air-of-refinement
branch
3 times, most recently
from
e14b9e7 to
9f3901f
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Note to self: Stick rdar://59125907 into the commit message too. |
CodaFi
force-pushed
the
an-air-of-refinement
branch
from
9f3901f to
36e5bb6
Compare
Add an algorithm to go search the override tables *and* the existing loaded members of a class for a redeclaration point. The idea is that both mirrored protocol members and categories offer a way to convince the Clang Importer to import a property twice. We support a limited form of this multiple-imports behavior today by allowing the redeclared property to refine a readonly property into a readwrite property. To maintain both the refinement behavior and to disambiguate any remaining cases of ambiguity caused by extensions, attempt to identify a redeclaration point if we can't identify an override point. Then, decline to import the redeclared member if we're successful. Note that the algorithm as presented is subject to import ordering. That is, if a framework declares both an overlay and a clang module unit, if the overlay is not loaded or members from the overlay are not installed in the class by the time we see the declaration we may fail to identify an redeclaration point. The regression tests are for rdar://59044692, rdar://59075988, and rdar://59125907.
CodaFi
force-pushed
the
an-air-of-refinement
branch
from
36e5bb6 to
e825ca1
Compare
CodaFi
changed the title
|
@swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an algorithm to go search the override tables and the existing
loaded members of a class for a redeclaration point. The idea is that
both mirrored protocol members and categories offer a way to convince
the Clang Importer to import a property twice. We support a limited form
of this multiple-imports behavior today by allowing the redeclared
property to refine a readonly property into a readwrite property.
To maintain both the refinement behavior and to disambiguate any
remaining cases of ambiguity caused by extensions, attempt to identify
a redeclaration point if we can't identify an override point. Then,
decline to import the redeclared member if we're successful.
Note that the algorithm as presented is subject to import ordering. That
is, if a framework declares both an overlay and a clang module unit, if
the overlay is not loaded or members from the overlay are not installed
in the class by the time we see the declaration we may fail to identify
a redeclaration point.