Pass -Xcc flags through swift-symbolgraph-extract #29568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jan 31, 2020
| @@ -66,6 +66,10 @@ PrettyPrint("pretty-print", llvm::cl::desc("Pretty-print the resulting Symbol Gr | |||
| static llvm::cl::opt<std::string> | |||
| MinimumAccessLevel("minimum-access-level", llvm::cl::desc("Include symbols with this access level or more"), llvm::cl::cat(Category)); | |||
|
|
|||
| static llvm::cl::list<std::string> | |||
| ClangXCC("Xcc", llvm::cl::desc("Pass the following command-line flag to Clang"), | |||
There was a problem hiding this comment.
Please don't name this ClangXcc, as it gets confusing since we do have some -clang-* flags in the driver to pass through options specifically to the clang as the linker driver. Could you please rename this to Xcc?
rdar://problem/59055039
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/59055039