SILGen: Plumb the source location of force-unwraps through the intrinsic. #2957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
force-pushed
the
optional-unwrap-source-loc
branch
from
e1ec938 to
b198bed
Compare
…sic. When a force-unwrap fails, show the source location of the '!' operator, not the line in the standard library that triggers the precondition.
|
@swift-ci Please test and merge |
|
Awesome, please mention this in the changelog! |
jckarter
added a commit
that referenced
this pull request
Jun 21, 2016
colemancda
pushed a commit
to colemancda/swift
that referenced
this pull request
Jun 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a force-unwrap fails, show the source location of the '!' operator, not the line in the standard library that triggers the precondition.