Skip to content

[AutoDiff] Fix windows build failure introduced in #29590. #29592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Feb 1, 2020

No description provided.

@rxwei
Copy link
Contributor Author

rxwei commented Feb 1, 2020

@compnerd is there a way to trigger a Windows build for this branch here?

@rxwei
Copy link
Contributor Author

rxwei commented Feb 1, 2020

Actually this needs a different fix. Will push soon.

@rxwei
Copy link
Contributor Author

rxwei commented Feb 1, 2020

@swift-ci please test tensorflow

1 similar comment
@rxwei
Copy link
Contributor Author

rxwei commented Feb 1, 2020

@swift-ci please test tensorflow

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@compnerd
Copy link
Member

compnerd commented Feb 1, 2020

@compnerd
Copy link
Member

compnerd commented Feb 2, 2020

I'm trying to get regular CI setup for Windows, and would like to get Windows CI going for tensorflow as well. Longer term, migrating to master will prove to be a better solution for CI.

@compnerd
Copy link
Member

compnerd commented Feb 2, 2020

The toolchain side of the build passed on Windows, this should be good to merge as soon as the macOS build is verified.

@compnerd
Copy link
Member

compnerd commented Feb 2, 2020

The Linux GPU builder is inaccessible, merging.

@compnerd compnerd merged commit 6b8983d into swiftlang:tensorflow Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants