[ownership] Trivial/Any have both been merged in ValueOwnershipKind::None for a long time so these code paths are unnecessary. #29606
+10
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…None for a long time so these code paths are unnecessary. Since non-payloaded cases of non-trivial enums have ValueOwnershipKind::None ownership, the compatibility maps that we return cause this case to just work as expected due to the way we merge.
|
@swift-ci test |
|
@swift-ci test windows platform |
|
@swift-ci test source compatibility |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since non-payloaded cases of non-trivial enums have ValueOwnershipKind::None
ownership, the compatibility maps that we return cause this case to just work as
expected due to the way we merge and the way compatibility maps work.
Specifically, a compatibility map no matter the base ownership kind, lifetime constraint will always accept .none as must be live.