Skip to content

Eliminate early semantic arc opts run. #29611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Feb 3, 2020

No description provided.

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2020

Performance: -O

Regression OLD NEW DELTA RATIO
String.replaceSubrange.RepChar.Small 353 406 +15.0% 0.87x (?)

Code size: -O

Improvement OLD NEW DELTA RATIO
NSDictionaryCastToSwift.o 1594 1546 -3.0% 1.03x

Performance: -Osize

Regression OLD NEW DELTA RATIO
String.replaceSubrange.RepChar.Small 354 404 +14.1% 0.88x (?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 42400 46500 +9.7% 0.91x (?)

Code size: -Osize

Improvement OLD NEW DELTA RATIO
NSDictionaryCastToSwift.o 1625 1577 -3.0% 1.03x

Performance: -Onone

Regression OLD NEW DELTA RATIO
ObjectiveCBridgeStubFromNSStringRef 205 262 +27.8% 0.78x (?)
String.replaceSubrange.RepChar.Small 361 412 +14.1% 0.88x (?)
RemoveWhereFilterStrings 3638 4076 +12.0% 0.89x (?)
FatCompactMap 419170 461650 +10.1% 0.91x (?)
WordCountUniqueUTF16 11890 13080 +10.0% 0.91x (?)
ObjectiveCBridgeStubFromNSDateRef 4310 4740 +10.0% 0.91x (?)
WordCountUniqueASCII 11470 12580 +9.7% 0.91x (?)
QueueGeneric 22470 24530 +9.2% 0.92x (?)
DictionaryCompactMapValuesOfCastValue 61668 67284 +9.1% 0.92x (?)
 
Improvement OLD NEW DELTA RATIO
NormalizedIterator_ascii 522 456 -12.6% 1.14x (?)
NormalizedIterator_latin1 830 750 -9.6% 1.11x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

@swift-ci benchmark

@gottesmm gottesmm changed the title [DRAFT] Experiment, eliminate early semantic arc opts run. Eliminate early semantic arc opts run. Feb 3, 2020
@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

Perf looks good. Going to disable this after updating tests.

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

Running benchmark again to double check.

@swift-ci
Copy link
Contributor

swift-ci commented Feb 3, 2020

Performance: -O

Code size: -O

Improvement OLD NEW DELTA RATIO
NSDictionaryCastToSwift.o 1594 1546 -3.0% 1.03x

Performance: -Osize

Regression OLD NEW DELTA RATIO
FlattenListLoop 2665 3166 +18.8% 0.84x (?)
IterateData 828 906 +9.4% 0.91x

Code size: -Osize

Improvement OLD NEW DELTA RATIO
NSDictionaryCastToSwift.o 1625 1577 -3.0% 1.03x

Performance: -Onone

Regression OLD NEW DELTA RATIO
Data.hash.Empty 94 102 +8.5% 0.92x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayOfGenericPOD2 836 751 -10.2% 1.11x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

Locally this seems not to make anything fail.

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 3, 2020

@swift-ci test windows platform

@gottesmm gottesmm merged commit aa5eb87 into swiftlang:master Feb 3, 2020
@gottesmm gottesmm deleted the pr-29886177aaeb616c1543a879b9e4ba37021106da branch February 3, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants