[AutoDiff] Improve getConstrainedDerivativeGenericSignature helper.
#29620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `getConstrainedDerivativeGenericSignature` under `autodiff` namespace. Improve naming and documentation.
marcrasi
approved these changes
Feb 3, 2020
|
@swift-ci Please smoke test |
rxwei
approved these changes
Feb 3, 2020
| /// - Differentiability parameter indices. | ||
| /// - A possibly "unconstrained" derivative generic signature. | ||
| GenericSignature | ||
| getConstrainedDerivativeGenericSignature(SILFunctionType *originalFnTy, |
There was a problem hiding this comment.
Why isn't there a version for ASTFunctionType?
There was a problem hiding this comment.
Good question - I guess an AnyFunctionType version hasn't been necessary for correctness.
I'm pretty sure the SILFunctionType version is necessary in the differentiation transform. So I don't believe an AnyFunctionType version can replace the SILFunctionType version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
getConstrainedDerivativeGenericSignatureunderautodiffnamespace.Improve naming and documentation.