[Constraint system] Simplify solution application target handling #29635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em all. Capture the peculiarities of contextual types vs. types used to generate conversion constraints, as well as the behavior of “optional some” patterns as used by if let / while let, within SolutionApplicationTarget. This allows us to use a single target throughout setup / solving / application, rather than mapping between two similar-but-disjoint targets.
…aint. We were storing more state than necessary in the constraint system.
|
@swift-ci please smoke test and merge |
xedin
approved these changes
Feb 4, 2020
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various simplifications to solution application target and contextual conversions.