Remove unneeded UndoManager test which inadvertently triggered driver error #29653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@jckarter I saw you linked to rdar://problem/17755906 in this test, which has something to do with proxy objects. Do you mind taking a look to see if these changes make sense? I'm not sure if this is a worthwhile fix or if I should just delete the test entirely. |
|
We can probably remove this test, since the issue of assigning through AnyObject dynamic dispatch has never been fixed. |
|
@jckarter sounds good to me, I'll just delete it then. Thanks for the context! |
|
@swift-ci please smoke test |
owenv
changed the title
DougGregor
approved these changes
Feb 9, 2020
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was inadvertently checking whether the driver diagnosed a lack of input files instead of whether the program typechecked. Discovered while debugging why it failed with swift-driver