Skip to content

[5.2][FunctionBodyTimer] Fix -warn-long-function-bodies, whose behavior was #29657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Feb 5, 2020

accidentally flipped with -debug-time-function-bodies.

This change flips the usage of ctx.TypeCheckerOpts.DebugTimeFunctionBodies and ctx.TypeCheckerOpts.WarnLongFunctionBodies in FunctionBodyTimer.


Cherry-picked from #29612

Resolves: rdar://problem/59149282

accidentally flipped with `-debug-time-function-bodies`
@hborla hborla requested review from DougGregor and CodaFi February 5, 2020 18:56
@hborla hborla requested a review from a team as a code owner February 5, 2020 18:56
@hborla
Copy link
Member Author

hborla commented Feb 5, 2020

@swift-ci please test

@hborla hborla merged commit fd192f4 into swiftlang:swift-5.2-branch Feb 5, 2020
@hborla hborla deleted the 5.2-warn-long-function-bodies branch February 5, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants