CI: expand %ProgramFiles% manually
#29716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands `%ProgramFiles%` manually since it is getting expanded to `C:\Program Files (x86)` rather than `C:\Program Files` as expected. Although this is less portable, this will at least enable the CI to run properly.
|
CC: @drodriguez |
|
@swift-ci please test Windows platform |
drodriguez
approved these changes
Feb 8, 2020
|
The reason that we couldn't figure it out is that the Java process is 32-bit which means that |
|
Why are you not using Java 64 bits? No problem using the 32 bits one, but is it an intentional choice? Also, no problem leaving the echo on. @swift-ci please smoke test and merge |
|
I couldn't find the 64-bit Java from their website without having to register. I just didn't want the hassle of the registration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands
%ProgramFiles%manually since it is getting expanded toC:\Program Files (x86)rather thanC:\Program Filesas expected.Although this is less portable, this will at least enable the CI to run
properly.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.