Python 3 removes the reduce builtin #2973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please Python lint |
|
@RLovelett Thank you! Would you mind looking at the linter issues? You can run the linter locally with |
RLovelett
force-pushed
the
python3-utils-update-checkout
branch
from
00157b8 to
b7c852a
Compare
This fix is merely the result of the suggestion in the Python 3 docs. See: https://docs.python.org/3.0/whatsnew/3.0.html#builtins
RLovelett
force-pushed
the
python3-utils-update-checkout
branch
from
b7c852a to
c955e6e
Compare
|
Fixed them. Thank you @gribozavr for all the work you do on this project. |
|
@swift-ci Please Python lint |
|
@RLovelett No, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Python 3 removes the
reducebuiltin. This fix is merely the result of the suggestion in the Python 3 docs.Perhaps the solution is a refactoring to use a
forloop as suggested in the docs. That's not really for me to say though as I understand next to nothing about Python or "preferred" methods. This was the smallest change I could make to get it back to working.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.