[SourceKit] Fix SyntaxModel assertion failure due to consuming tokens twice or out of order #29769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nathawes
force-pushed
the
fix-syntax-model-assertion-failures
branch
from
dcd0159 to
7e66dab
Compare
nathawes
changed the title
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
nathawes
force-pushed
the
fix-syntax-model-assertion-failures
branch
from
7e66dab to
fcbb779
Compare
|
@swift-ci please smoke test |
…s twice or prematurely The SyntaxModel walker would end up visiting the attributes attached to a PatternBindingDecl twice if it contained more than one VarDecl, hitting the below assertion on the second visit because the tokens corresponding to the attribute had already been consumed the first time around: ``` Assertion failed: (0 && "Attribute's TokenNodes already consumed?"), function handleSpecialDeclAttribute ``` It would also hit the same assertion for attributes on an EnumCaseDecl, but even when it only had a single child EnumElementDecl. This because when we visited the EnumCaseDecl and pushed its structure node, we'd consume and emit any tokens before it's start position. This meant that when we tried to process the attributes attached to the child EnumElementDecl its tokens had already been consumed, triggering the assertion. In both cases the attributes syntactically attach to the parent PatternBindingDecl or EnumCaseDecl, but in the AST they're accessed via their child VarDecls or EnumElementDecls. Resolves rdar://problem/53747546
nathawes
force-pushed
the
fix-syntax-model-assertion-failures
branch
from
fcbb779 to
5e1985c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SyntaxModel walker would end up visiting the attributes attached to a PatternBindingDecl twice if it contained more than one VarDecl, hitting the below assertion on the second visit because the tokens corresponding to the attribute had already been consumed the first time around:
It would also hit the same assertion for attributes on an EnumCaseDecl, but even when it only had a single child EnumElementDecl. This because when we visited the EnumCaseDecl and pushed its structure node, we'd consume and emit any tokens before it's start position. This meant that when we tried to process the attributes attached to the child EnumElementDecl its tokens had already been consumed, triggering the assertion.
In both cases the attributes syntactically attach to the parent PatternBindingDecl or EnumCaseDecl, but in the AST they're accessed via their child VarDecls or EnumElementDecls.
Resolves rdar://problem/53747546