[gyb] Add gyb doctest to validation-test #2980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
gyb-validation-test
branch
from
c7ef749 to
46a6df2
Compare
|
@swift-ci Please smoke test |
| @@ -0,0 +1,4 @@ | |||
| // RUN: %{python} -m doctest %S/../../utils/gyb.py | |||
| // RUN: echo 'Hello ${ME}' | %S/../../utils/gyb --test -DME=Swift | FileCheck %s | |||
| // RUN: echo 'Hello ${ME}' | %S/../../utils/gyb --verbose-test -DME=Swift | FileCheck %s | |||
There was a problem hiding this comment.
Could you use the %gyb substitution? You can also add a %gyb-py one to test/lit.cfg.
There was a problem hiding this comment.
@gribozavr I'm actually preparing lit substitutions patch
master...rintaro:tests-substitution-utils
There was a problem hiding this comment.
Great! Sorry, I didn't realize that we were using %S/../../../utils/gyb in other tests.
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: DO NOT MERGE BEFORE #2978
What's in this pull request?
Added
gybdoctest to validation test asvalidation-test/Python/gyb.swiftRemoved
--testoption from normalgybinvocation inCMakeLists.txt.While I agree with the comment:
Do we really need it?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.