Canonicalize the components of a GenericFunctionType in the context o… #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test. |
…f the generic signature. This is obviously the right thing to do in terms of ensuring that two different expressions of the same signature always result in the same type. It also has the pleasant side-effect of causing the canonical function type to never be expressed in terms of type parameters which have been equated with concrete types, which means that various consumers that work primarily with canonical types (such as SILGen and IRGen) no longer have to worry about such types, at least when decomposing a generic function signature.
rjmccall
force-pushed
the
canonicalize-generic-function-type
branch
from
d8975c6 to
fdd25a3
Compare
|
@swift-ci Please test. |
|
I don't think the Linux failures are related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Canonicalizes the components of a GenericFunctionType in the context of the generic signature for general correctness and to eliminate of some persistent and frustrating corner cases in SIL generic function type lowering.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
…f the generic signature.
This is obviously the right thing to do in terms of ensuring
that two different expressions of the same signature always result
in the same type. It also has the pleasant side-effect of causing
the canonical function type to never be expressed in terms of type
parameters which have been equated with concrete types, which means
that various consumers that work primarily with canonical types
(such as SILGen and IRGen) no longer have to worry about such types,
at least when decomposing a generic function signature.