[ownership] When we flag an over consume, improve error msg by dumping consuming user list. #29872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g consuming user list. Specifically, there are a few places in the ownership data flow where before this patch we just dumped the violating user and the block where the overconsume occurred. Since we only dumped the block rather than consuming user list, it could require a little bit of time/energy to identify why the block was considered to already have a consume in it. So at least by dumping the consuming user list, the compiler writer has more information to reason about this.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, there are a few places in the ownership data flow where before
this patch we just dumped the violating user and the block where the overconsume
occurred. Since we only dumped the block rather than consuming user list, it
could require a little bit of time/energy to identify why the block was
considered to already have a consume in it. So at least by dumping the consuming
user list, the compiler writer has more information to reason about this.