[NFC] Update required CMake version in README.md #29891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Feb 18, 2020
compnerd
requested changes
Feb 18, 2020
There was a problem hiding this comment.
I think that we should make this clearer. 3.4.3 is sufficient - we can build CMake 3.15 with that and will do so. This happens via build-script already. If you are building without build-script, you are responsible for knowing the details of what happens in the implementation.
|
@compnerd I've clarified the text mentioning both versions and in which cases these requirements are applicable. |
compnerd
approved these changes
Feb 19, 2020
|
@swift-ci please smoke test |
|
@compnerd I don't think OS X failure is related. Can this be merged yet? |
|
@compnerd ping |
|
@compnerd would you have another look please? Is there anything that prevents this from being merged? |
|
Closing as subsumed by #30695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when building on Ubuntu, the system installed version (which is older than 3.15.1) is not sufficient, the required version should be specified explicitly.