Skip to content

[Sema] Fix DerivedConformanceDifferentiable.cpp header order. #29919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

dan-zheng
Copy link
Contributor

Fixes breakages introduced in #29908.
Breakages due to not running tests after clang-format.
Breakages not caught because @swift-ci Please test tensorflow was down.


Fixed errors:

[2/4] Building CXX object lib/Sema/CMakeFil....dir/DerivedConformanceDifferentiable.cpp.o
FAILED: lib/Sema/CMakeFiles/swiftSema.dir/DerivedConformanceDifferentiable.cpp.o
...
In file included from /home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformanceDifferentiable.cpp:21:
/home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformances.h:372:10: error: unknown type name 'GuardStmt'
  static GuardStmt *returnIfNotEqualGuard(ASTContext &C, Expr *lhsExpr,
         ^
/home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformances.h:376:10: error: unknown type name 'GuardStmt'
  static GuardStmt *returnFalseIfNotEqualGuard(ASTContext &C, Expr *lhsExpr,
         ^
/home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformances.h:379:10: error: unknown type name 'GuardStmt'
  static GuardStmt *
         ^
/home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformances.h:408:38: error: use of undeclared identifier 'ASTNode'
  convertEnumToIndex(SmallVectorImpl<ASTNode> &stmts, DeclContext *parentDC,
                                     ^
/home/danielzheng/swift-dev/swift/lib/Sema/DerivedConformances.h:413:32: error: unknown type name 'EnumElementDecl'
  enumElementPayloadSubpattern(EnumElementDecl *enumElementDecl, char varPrefix,
                               ^
5 errors generated.

Fixes breakages introduced in swiftlang#29908.
Breakages due to not running tests after `clang-format`.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Feb 19, 2020
@dan-zheng dan-zheng requested review from rxwei and marcrasi February 19, 2020 05:57
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow still appears to be down.
ninja check-swift passes locally so I'll merge this now.

@dan-zheng dan-zheng merged commit 61c6862 into swiftlang:tensorflow Feb 19, 2020
@dan-zheng dan-zheng deleted the fix-derived-conformances branch February 19, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants