[swift-lang] Fix dependency on sourcekitd module #29925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link dependency is not sufficient, because this code depends on the sourcekitd header and module map, which are produced during the build process. This started failing after edbe22b, where the dependency on `sourcekitd-test` was removed. That dependency was itself wrong, but it happened to be a good enough approximation that we never saw issues.
|
@swift-ci please smoke test |
|
@benlangmuir oh, ugh, sorry! Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link dependency is not sufficient, because this code depends on the
sourcekitd header and module map, which are produced during the build
process. This started failing after edbe22b, where the dependency
on
sourcekitd-testwas removed. That dependency was itself wrong,but it happened to be a good enough approximation that we never saw
issues.