Handle partial_apply and mark_dependence in Temp RVO #29927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes some of the changes in #29812 |
|
@swift-ci please test |
| @@ -1873,7 +1877,7 @@ bool TempRValueOptPass::tryOptimizeCopyIntoTemp(CopyAddrInst *copyInst) { | |||
| continue; | |||
|
|
|||
| // Destroys and deallocations are allowed to be in a different block. | |||
| if (isa<DestroyAddrInst>(user) || isa<DeallocStackInst>(user)) | |||
| if (isa<DestroyAddrInst>(user) || isa<DeallocStackInst>(user) || isa<MarkDependenceInst>(user)) | |||
There was a problem hiding this comment.
Don't we have to check the uses of the mark_dependence instruction?
There was a problem hiding this comment.
You are right. Looks like I do need to look at its uses. And one of its uses is another partial_apply which is marked as having side effects in AliasAnalysis.
|
Closing this PR. The pattern I was trying to optimize shouldn't be generated in SIL in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial_apply and mark_dependence do not have any side effects that could block Temp RVO. Handle these additional cases.