[Sema] Always install property wrappers during qualified lookup #29937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the property wrappers part of dd51251. Every part of the qualified lookup stack needs to synthesize property wrapper members, otherwise we'll be subject to the relativistic effects of semantic lookups in different files. Besides, Codable was the main source of cycles and circularity under the old scheme. Resolves rdar://59531889
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci clean test source compatibility |
|
@swift-ci test source compatibility |
slavapestov
approved these changes
Feb 20, 2020
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the property wrappers part of dd51251.
Every part of the qualified lookup stack needs to synthesize property
wrapper members, otherwise we'll be subject to the relativistic effects
of semantic lookups in different files. Besides, Codable was the main
source of cycles and circularity under the old scheme.
Resolves rdar://59531889