Skip to content

Revert "[SILOptimizer] Generalize optimization of static keypaths" #29946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

Revert "[SILOptimizer] Generalize optimization of static keypaths" #29946

merged 1 commit into from
Feb 21, 2020

Conversation

jckarter
Copy link
Contributor

Reverts #28799. It still causes a failure in test/stdlib/KeyPath.swift on i386:

[ RUN      ] key paths.optional force-unwrapping
stderr>>> Assertion failed: (getStrongExtraRefCount() + 1 >= dec && "releasing reference whose refcount is already zero"), function decrementStrongExtraRefCount, file /Users/buildslave/jenkins/workspace/fs-swift-unreleased-master-tools_RA-stdlib_RA/swift/include/swift/Runtime/../../../stdlib/public/SwiftShims/RefCount.h, line 576.
stderr>>> CRASHED: SIGABRT
the test crashed unexpectedly

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@jckarter jckarter merged commit 83668f9 into master Feb 21, 2020
@jckarter jckarter deleted the revert-28799-master branch February 21, 2020 20:47
@jckarter jckarter mentioned this pull request Feb 21, 2020
Merged
@NobodyNada NobodyNada mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jckarter