Skip to content

[Tests] Mark some CrossImport tests as unsupported on Windows #29962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devincoughlin
Copy link
Contributor

Unblock Windows testing by marking some CrossImport tests as
unsupported on Windows.

Unblock Windows testing by marking some CrossImport tests as
unsupported on Windows.
@devincoughlin
Copy link
Contributor Author

@swift-ci please smoke test and merge

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mark this as unsupported on Windows. It should be treated as a failure on macOS.

@compnerd
Copy link
Member

The underlying issues here were addressed right? Is this still useful @devincoughlin?

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants