Skip to content

test: fix for Windows #29965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

test: fix for Windows #29965

merged 1 commit into from
Feb 20, 2020

Conversation

compnerd
Copy link
Member

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please smoke test and merge

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about this—I think I asked swift-ci for Windows PR tests a couple times and never got them.

@compnerd
Copy link
Member Author

@brentdax - that sounds like something that @shahmishal should look into (could you please file a radar?) - you should be able to trigger those

@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

The Windows failure is going to be addressed by #29967, merging to improve the state

@compnerd compnerd merged commit 386f6d6 into swiftlang:master Feb 20, 2020
@compnerd compnerd deleted the 29582-1 branch February 20, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants