Skip to content

Remove some unused Sema diagnostic messages #29970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove some unused Sema diagnostic messages #29970

merged 1 commit into from
Feb 20, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Feb 20, 2020

found using /utils/find-unused-diagnostics.sh. Most of these were obsoleted when CSDiag was deleted, a couple may be older.

@owenv
Copy link
Contributor Author

owenv commented Feb 20, 2020

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Feb 20, 2020

cc @xedin , @hborla just in case there are plans to bring some of these back in the future. For the most part it looks like they've all been replaced by new, better messages 🎉

xedin
xedin approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you have mentioned, we do have better versions for almost all of these messages, besides maybe for "escaping in context" but that has a better diagnostic because it's possible detect the type exactly now.

@owenv owenv merged commit 1b07853 into swiftlang:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenv @xedin