Skip to content

IRGen: correct the typecast (NFC) #29993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

compnerd
Copy link
Member

This seems unused currently, as attempting to query the DeclContext of
these types results in an immediate assertion that the kind of entity is
invalid. These are non-root protocol conformances, use
getProtocolConformance instead of the copy-paste value of
getRootProtocolConformance.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This seems unused currently, as attempting to query the DeclContext of
these types results in an immediate assertion that the kind of entity is
invalid.  These are non-root protocol conformances, use
`getProtocolConformance` instead of the copy-paste value of
`getRootProtocolConformance`.
@compnerd
Copy link
Member Author

CC: @slavapestov

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 0626dc7 into swiftlang:master Feb 22, 2020
@compnerd compnerd deleted the conform-to-your-conformance branch February 22, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant