[AutoDiff] forbid derivative registration using @differentiable #30002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Feb 21, 2020
dan-zheng
approved these changes
Feb 21, 2020
|
I accidentally deleted |
|
Test run caught some 'vjp:' in OpenSpiel! I'll fix that before proceeding with merging this PR. |
OpenSpiel
pushed a commit
to google-deepmind/open_spiel
that referenced
this pull request
Feb 26, 2020
This change unblocks deprecation of @differentiable(vjp:) (swiftlang/swift#30002). PiperOrigin-RevId: 297439933 Change-Id: I0aad361fc9ae7091d7e49670a95f91b103d0f117
marcrasi
force-pushed
the
tf-remove-differentiable-jvp-vjp
branch
2 times, most recently
from
ca3311b to
ab83c95
Compare
|
@swift-ci please test tensorflow |
|
This seems good to go now, but I'll wait until we have caught up with the master->tensorflow merge so that I don't further pile on conflicts. |
marcrasi
force-pushed
the
tf-remove-differentiable-jvp-vjp
branch
from
a439d6f to
4544f5e
Compare
marcrasi
force-pushed
the
tf-remove-differentiable-jvp-vjp
branch
from
61a66ec to
88dabef
Compare
marcrasi
force-pushed
the
tf-remove-differentiable-jvp-vjp
branch
from
88dabef to
7f2495e
Compare
|
@swift-ci please test tensorflow |
|
Merging now that upstream mirror #30001 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
tensorflowbranch PR corresponding to #30001. Repeating the description:Forbids the
jvp:andvjp:arguments to@differentiable, deletes all the logic that handles them, and updates tests to use@derivative(of:)instead.I left an error message saying that
jvp:andvjp:are deprecated, so that there is a good explanation for anyone who missed the deprecation warning and whose code stops working. I think we should wait until next release to remove this.I am running all the swift-apis, swift-models, swift-jupyter, swiftai, etc tests on this to catch any leftover
jvp:orvjp:that we forgot to remove.