If -verify mode saw unexpected diagnostics, print diagnostics from all files.
#30028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
…all files. As an example of how this is useful, consider the case where ClangImporter fails with "unexpected error produced: could not build C module 'ctypes'" It would be useful to know what the underlying Clang error was that caused building the module to fail, but so far, `-verify` mode would not output that; to get the error, it would be necessary to run the compiler invocation again without `-verify`. This change causes any remaining diagnostics that weren't in the input file to be output if there were unexpected diagnostics in `-verify` mode. I haven't added any tests for this because I didn't find a place that contains tests for the `-verify` functionality itself (as opposed to tests that use `-verify` mode). I think the large number of tests that run with `-verify` should at least ensure, however, that this change does not regress anything.
A header shouldn't contain a function body unless the function is inline. Following gribozavr's suggestion, I'm using the easier solution of omitting the semicolon from the function prototype. (In response to review comments.)
Shorten expected error message so that it doesn't expect "C module" (and breaks if presented with "Objective-C module").
|
Pushed a rebase to get off a bad version with failing LLDB tests. Please retest. |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
gribozavr
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes any remaining diagnostics that weren't in the input file to be output if there were unexpected diagnostics in
-verifymode.As an example of how this is useful, consider the case where ClangImporter fails with
It would be useful to know what the underlying Clang error was that caused building the module to fail, but so far,
-verifymode would not output that; to get the error, it would be necessary to run the compiler invocation again without-verify.The PR adds a test that exercises this use case.
I'm also adding some basic tests for the
-verifyfunctionality generally, which didn't seem to exist.