[ConstraintSystem] Look through l-value while checking whether dynami… #30040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c key path is recursive Fix a crash in dynamic member lookup attempting to recursively lookup a member on the same base type. The problem is related to `isSelfRecursiveKeyPathDynamicMemberLookup` which failed to look through l-value wrapping base type on each side of the comparison, that's important because it's possible to have l-value mismatch due to the fact that implicit call always gets l-value base type but actual subscript which triggered dynamic lookup might be r-value. Resolves: [SR-11743](https://bugs.swift.org/browse/SR-11743) Resolves: rdar://problem/57091169
|
@swift-ci please smoke test |
theblixguy
reviewed
Feb 25, 2020
|
@theblixguy No problem! Would really appreciate if you could help me find the dupes :) |
|
I think one of them is linked to that ticket, I did a quick search but I can't find the dupes, but I do remember seeing a few crashes which were probably related to this. Maybe I was looking at something else. Anyway, I've run into this exact crash many times, so really happy to see it finally being fixed. Here's another test case that you can add (which causes the same crash, but doesn't use protocols or default implementation): @dynamicMemberLookup
struct Foo {
let value: Int
subscript<T>(dynamicMember member: KeyPath<Self, T>) -> T {
return self[keyPath: member]
}
} |
|
Thank you! We definitely want as many test-cases as possible! :) |
|
Hm, looks like GitHub didn't pick up my new commit, I'll give it some time. |
|
Ok, here we go. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c key path is recursive
Fix a crash in dynamic member lookup attempting to recursively
lookup a member on the same base type.
The problem is related to
isSelfRecursiveKeyPathDynamicMemberLookupwhich failed to look through l-value wrapping base type on each side of
the comparison, that's important because it's possible to have l-value
mismatch due to the fact that implicit call always gets l-value base
type but actual subscript which triggered dynamic lookup might be r-value.
Resolves: SR-11743
Resolves: rdar://problem/57091169