Skip to content

tensorflow: streamline the installation rules a bit #30047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

compnerd
Copy link
Member

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd compnerd changed the base branch from master to tensorflow February 25, 2020 19:34
- Use a decorator to silence the failure of the file system operation.
- Ensure that we set the correct permissions on the installed library.
- Use an absolute path to `configure` for tensorflow as this fails to
  build on some machines otherwise.
@compnerd compnerd changed the title Clarify tensorflow: streamline the installation rules a bit Feb 25, 2020
@compnerd
Copy link
Member Author

@swift-ci please test tensorflow

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explicitly _internal APIs!

@compnerd compnerd merged commit 7c34fa5 into swiftlang:tensorflow Feb 26, 2020
@compnerd compnerd deleted the clarify branch February 26, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants