ClangImporter: share more of the clang invocation #3005
Conversation
|
CC @jrose-apple |
|
I think the fact that Linux and Darwin both use |
|
It seems like it would be nicer to keep all the targets in as much parity as possible. I was thinking of actually proposing to require libBlocksRuntime on Linux, and pushing |
|
@jrose-apple ping |
|
Sorry, I'm not convinced. Apple platforms really are different from everything else, and they will continue to be for a long time to come. I like the reorganization of the flags that are truly common, but the rest of them are all things we depend on for correctness in all configurations. |
compnerd
force-pushed
the
clang-invocation
branch
from
cee2df9 to
449bd58
Compare
|
@jrose-apple okay, well, this just reorders the arguments to be more logically grouped that you were still in favor of. |
| @@ -384,8 +387,6 @@ getNormalInvocationArguments(std::vector<std::string> &invocationArgStrs, | |||
| invocationArgStrs.insert(invocationArgStrs.end(), { | |||
| // Non-Darwin platforms don't use the Objective-C runtime, so they can | |||
| // not import Objective-C modules. | |||
| // | |||
| // Just use the most feature-rich C language mode. | |||
There was a problem hiding this comment.
This comment is still relevant, isn't it?
There was a problem hiding this comment.
Ah, right, that should remain. Ill update that shortly.
Reorganise the options to be grouped together by purpose. NFC.
compnerd
force-pushed
the
clang-invocation
branch
from
449bd58 to
f99dda5
Compare
|
@swift-ci Please smoke test |
|
@jrose-apple any other comments on this? |
|
Nope, all good! |
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
This shares more of the clang invocation options across the various targets. It
makes it easier to see what options actually differ. Take the opportunity to
reorganise the options to be clustered by purpose.