[Constraint system] Cleanups for function builders support for if let/if case let #30065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle StmtCondition as part of SolutionApplicationTarget, so we can generate constraints from it and rewrite directly as part of a solution, rather than open-coding the operation in the function builder transform.
Teach pattern matching involving "as" patterns to work properly in function builders. The code almost handled this, but prematurely prechecking expressions in patterns broke it.
|
@swift-ci please smoke test and merge |
xedin
approved these changes
Feb 26, 2020
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
Failure is unrelated to my change (this time). |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups to improve function builders support for if let/if case let:
SolutionApplicationTargettoStmtConditions.aspatterns by not prechecking patterns (oops).