[Sema] Implement type erasure for dynamic replacement. #30101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamically replaceable function returns an opaque type.
|
@swift-ci please smoke test |
xedin
approved these changes
Feb 27, 2020
DougGregor
approved these changes
Feb 29, 2020
| Printer << "("; | ||
| Printer.callPrintNamePre(PrintNameContext::Attribute); | ||
| auto typeLoc = cast<TypeEraserAttr>(this)->getTypeEraserLoc(); | ||
| if (auto type = typeLoc.getType()) |
There was a problem hiding this comment.
There's an option to prefer the TypeRepr when printing. Can you check willUseTypeReprPrinting in this conditional?
| @@ -520,7 +520,7 @@ SIMPLE_DECL_ATTR(_inheritsConvenienceInitializers, | |||
| 93) | |||
|
|
|||
| DECL_ATTR(_typeEraser, TypeEraser, | |||
| OnProtocol | UserInaccessible | NotSerialized | | |||
There was a problem hiding this comment.
Hmm. Please bump the version number in ModuleFormat.h to account for this.
| @@ -7417,6 +7417,7 @@ ExprWalker::rewriteTarget(SolutionApplicationTarget target) { | |||
| return None; | |||
|
|
|||
| result.setFunctionBody(newBody); | |||
| fn.getAbstractFunctionDecl()->setHasSingleExpressionBody(false); | |||
There was a problem hiding this comment.
Anything that calls hasSingleExperssionBody and subsequently calls getSingleExpressionBody after the function builder transformation is applied will crash. In my case it was -dump-ast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before generating constraints for an expression that could potentially be a return value, perform type erasure on this expression if needed. An expression needs type erasure if:
Resolves: rdar://problem/58763698