Skip to content

IRGen: Invoke objc_opt_self directly when available. #30105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

IRGen: Invoke objc_opt_self directly when available. #30105

merged 2 commits into from
Mar 3, 2020

Conversation

jckarter
Copy link
Contributor

We don't need swift_getInitializedObjCClass on new enough Apple OSes because
the ObjC runtime provides an equivalent call for us.

@jckarter jckarter requested a review from mikeash February 27, 2020 21:45
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c6c80b973dd077d749a3ecc703e6224b1dd39ae6

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c6c80b973dd077d749a3ecc703e6224b1dd39ae6

compnerd
compnerd reviewed Feb 27, 2020
View reviewed changes
@jckarter
IRGen: Invoke objc_opt_self directly when available.
4abb548 
We don't need swift_getInitializedObjCClass on new enough Apple OSes because
the ObjC runtime provides an equivalent call for us.
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4abb548

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4abb548

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4abb548

@jckarter
Copy link
Contributor Author

jckarter commented Mar 2, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 5b8c16e6212d43af60bf82cd4728304e54c473de

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - 5b8c16e6212d43af60bf82cd4728304e54c473de

@jckarter
Remove explicit target(s) from reflect_empty_struct tests
e844771 
Swift CI tests backward deployment on different host OSes, so this should be covered in
testing. The explicit target doesn't work well with `executable_test` since it leads to
binaries with too-new minimum deployment targets getting executed on older host OSes.
@jckarter
Copy link
Contributor Author

jckarter commented Mar 2, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - 479b09ed93825403f2ca14ccf76e25f18a789ee3

@swift-ci
Copy link
Contributor

swift-ci commented Mar 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 479b09ed93825403f2ca14ccf76e25f18a789ee3

@jckarter
Copy link
Contributor Author

jckarter commented Mar 3, 2020

@swift-ci Please test

@jckarter jckarter merged commit d8e8b3d into swiftlang:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jckarter @swift-ci @compnerd @mikeash