Make String(unsafeUninitializedCapacity:initializingUTF8With:) public #30106
Conversation
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
Should the public initializer include the |
|
Oh did I get that backwards? For some reason I thought we'd ended up removing it. Thanks for catching that! Also what is swift-ci doing :( |
This comment has been minimized.
This comment has been minimized.
| @@ -476,7 +476,8 @@ extension String { | |||
| /// - buffer: A buffer covering uninitialized memory with room for the | |||
| /// specified number of UTF-8 code units. | |||
| @inline(__always) | |||
| internal init( | |||
| @available(macOS 9999, iOS 9999, tvOS 9999, watchOS 9999, *) | |||
| public init( | |||
There was a problem hiding this comment.
From the proposal:
public init(
unsafeUninitializedCapacity capacity: Int,
initializingUTF8With initializer: (
_ buffer: UnsafeMutableBufferPointer<UInt8>,
) throws -> Int
) rethrows
|
@swift-ci please test and merge |
|
@swift-ci please smoke test and merge |
|
The |
xwu
changed the title
|
Huh when did lowercased() and friends start using this, that's neat |
|
Also I have to work around availability >.< |
Catfish-Man
force-pushed
the
going-public
branch
from
8afb1ba to
b9ddaa6
Compare
|
@swift-ci please test and merge |
|
The public and internal initializers are And if the callers I listed above ( The "test and merge" failed.
You could try a "test" only, and merge manually if that works. |
|
Yes, inline always but not inlinable was intentional here. I want to try taking that off at some point, but getting the SmallString part inlined as much as possible is important (originally I wanted to make it inlinable, but SmallString isn't ABI). I tried using the public initializer in lowercased() and friends but it still got upset about availability :( test only is a good idea, let's try that |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
All checks have passed! |
No description provided.