build: specify a compiler target for pythonkit on macOS #30121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
|
I'm assuming |
|
UGH, the online editor :-( this was meant for the tensorflow branch |
|
Build failed |
Because the rest of the components have a deployment target of 10.13 explicitly, pass the same triple for the PythonKit build.
compnerd
force-pushed
the
compnerd-pythonkit-deployment-version
branch
from
17ddcda to
1575480
Compare
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the rest of the components have a deployment target of 10.13 explicitly, pass the same triple for the PythonKit build.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.