Skip to content

Update test for Windows path #30125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2020
Merged

Update test for Windows path #30125

merged 2 commits into from
Feb 29, 2020

Conversation

benlangmuir
Copy link
Contributor

Update #30059 test for Windows path separators

@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

@swift-ci please test Windows

@benlangmuir benlangmuir mentioned this pull request Feb 28, 2020
Merged
owenv
owenv approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, was just about to make the same change

@benlangmuir benlangmuir mentioned this pull request Feb 28, 2020
Closed
@owenv
Copy link
Contributor

owenv commented Feb 28, 2020

This should fix the test I added, but I don't know why ModuleInterface/ModuleCache/module-cache-diagnostics.swift is failing on Windows

@compnerd
Copy link
Member

compnerd commented Feb 28, 2020 •
edited
Loading

@owenv that seems to be flakey? Ignore Windows failures and merge as long as this particular test passes. Im going to see if I can investigate that in parallel.

@benlangmuir
Copy link
Contributor Author

@swift-ci please test Windows

@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

@swift-ci please test Windows

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@owenv
Copy link
Contributor

owenv commented Feb 28, 2020

@swift-ci please smoke test

@owenv
Copy link
Contributor

owenv commented Feb 28, 2020

@swift-ci please test Windows platform

@owenv
Copy link
Contributor

owenv commented Feb 28, 2020

Linux test failure is unrelated

@swift-ci please smoke test Linux

@owenv owenv merged commit 05e6364 into swiftlang:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@owenv owenv owenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlangmuir @owenv @compnerd