Skip to content

Removes redundant buffer zeroing in CGColorSpace.swift by using `init(unsafeUninitializedCapacity:initializingWith:) #30134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2020
Merged

Removes redundant buffer zeroing in CGColorSpace.swift by using `init(unsafeUninitializedCapacity:initializingWith:) #30134

merged 2 commits into from
Apr 14, 2020

Conversation

valeriyvan
Copy link
Contributor

@valeriyvan valeriyvan commented Feb 28, 2020 •
edited
Loading

In colorTable getter removes redundant buffer zeroing by using init(unsafeUninitializedCapacity:initializingWith:) instead of init(repeating:count:)

@theblixguy
Copy link
Collaborator

theblixguy commented Feb 28, 2020 •
edited
Loading

Hi @valeriyvan

Do you mind updating the title of this PR and the other PRs you’ve recently created? It might be a little confusing for reviewers to keep track of what each PR does if they are all titled the same. It would be great if you can update the description too.

Thank you!

@valeriyvan valeriyvan changed the title Removes redundant buffer zeroing Removes redundant buffer zeroing in CGColorSpace.swift by using `init(unsafeUninitializedCapacity:initializingWith:)z Feb 28, 2020
@valeriyvan valeriyvan changed the title Removes redundant buffer zeroing in CGColorSpace.swift by using `init(unsafeUninitializedCapacity:initializingWith:)z Removes redundant buffer zeroing in CGColorSpace.swift by using `init(unsafeUninitializedCapacity:initializingWith:) Feb 28, 2020
@valeriyvan
Copy link
Contributor Author

@theblixguy, is it now better?

@theblixguy
Copy link
Collaborator

Yeah, could you do that for #30131, #30132, #30133 as well since they also have the same title as this one was before?

@valeriyvan
Copy link
Contributor Author

Done

@milseman
Copy link
Member

milseman commented Mar 4, 2020

@lorentey this is a change against the CoreGraphics overlay. What is the best way to review and incorporate these kinds of changes?

@valeriyvan
Copy link
Contributor Author

ping

@milseman
Copy link
Member

@lorentey any news here?

@lorentey
Copy link
Member

@swift-ci test

lorentey
lorentey approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 60d9bf2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 60d9bf2

@lorentey
Copy link
Member

Linux failure looks unrelated, but the macOS build has the same issue as #30133. @valeriyvan

@valeriyvan
Copy link
Contributor Author

ping

@lorentey
Copy link
Member

lorentey commented Apr 3, 2020

@swift-ci test

@lorentey lorentey merged commit 9821976 into swiftlang:master Apr 14, 2020
@valeriyvan valeriyvan deleted the RemoveRedundantZeroingCGColorSpace branch February 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees

@lorentey lorentey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valeriyvan @theblixguy @milseman @lorentey @swift-ci