[stdlib] StaticString documentation and tests #30146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrimmington
force-pushed
the
static-string-documentation
branch
5 times, most recently
from
4629e8e to
bd7b72f
Compare
|
Cc: @natecook1000 |
natecook1000
reviewed
Mar 3, 2020
There was a problem hiding this comment.
Great revisions, @benrimmington! StaticString is such an odd type. Some nits and editorial feedback below, tagging @amartini51 as well.
Co-Authored-By: Nate Cook <[email protected]>
benrimmington
force-pushed
the
static-string-documentation
branch
from
10018e3 to
f5fe8e3
Compare
|
@swift-ci Please smoke test |
|
@natecook1000 Thanks for reviewing this. Please merge if possible. |
|
@natecook1000 Does anyone else need to review this? |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation (and tests) for null-terminated static strings.
The
isASCIIAPI has been tested (since Swift 1.1) for both representations.4f38403