[ConstraintSystem] Don't record general contextual mismatch if there are restrictions present #30160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It detends on a situation whether try? would get a type inferred so the mismatch is against a contextual type, or contextual type would be used as a type of `try?` and fail comparsion with inner expression type. In either case the mismatch is contextual.
… points directly to a specific expression
…are restrictions present If there are any conversion restrictions present while trying to repair failures related to contextual type, let's give `simplifyRestrictedConstraintImpl` a chance to run and fix the problem. Resolves: rdar://problem/59773317
|
@swift-ci please smoke test |
hborla
approved these changes
Mar 2, 2020
| // expected-error@-1 {{generic parameter 'R' could not be inferred}} expected-note@-1 {{explicitly specify the generic arguments to fix this issue}} | ||
| // expected-error@-2 {{cannot convert return expression of type 'E_32551313<String, R>' to return type 'E_32551313<(String, Foo_32551313?), (String, String)>?'}} | ||
| return E_32551313.Left("", Foo_32551313()) | ||
| // expected-error@-1 {{cannot convert value of type 'String' to expected argument type '(String, Foo_32551313?)'}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any conversion restrictions present while trying to repair
failures related to contextual type, let's give
simplifyRestrictedConstraintImpla chance to run and fix the problem.
Resolves: rdar://problem/59773317