Skip to content

[interface-gen] Avoid double-printing mutating #30183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

benlangmuir
Copy link
Contributor

Revert a small change from dfe00c3 that caused us to start
double-printing the mutating keyword on functions.

rdar://59899776

Revert a small change from dfe00c3 that caused us to start
double-printing the `mutating` keyword on functions.

rdar://59899776
@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Mar 3, 2020

@benlangmuir There's already a PR hanging to fix the issue. The problem is, there isn't much I can do other than ask someone to review. Do we really need to revert the whole thing?

@benlangmuir
Copy link
Contributor Author

There's already a PR hanging to fix the issue.

Cool thanks, I'll take a look.

Do we really need to revert the whole thing?

I didn't revert the whole thing, I just added back the check for hasAttribute<MutatingAttr>.

@AnthonyLatsis
Copy link
Collaborator

I didn't revert the whole thing, I just added back the check for hasAttribute.

I see, got the wrong idea. Thanks!

@benlangmuir
Copy link
Contributor Author

Closing in favour of #30011

@benlangmuir benlangmuir closed this Mar 3, 2020
@benlangmuir benlangmuir deleted the mutating-mutating branch March 3, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants