Skip to content

Changes implementation of _persistCString from _StringGuts #30237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2020
Merged

Changes implementation of _persistCString from _StringGuts #30237

merged 2 commits into from
Mar 9, 2020

Conversation

valeriyvan
Copy link
Contributor

Changes implementation of _persistCString from _StringGuts to be in sync with implementation from stdlib PR

@theblixguy theblixguy requested a review from milseman March 5, 2020 15:29
milseman
milseman approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milseman
Copy link
Member

milseman commented Mar 5, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - 190b8a7

@swift-ci
Copy link
Contributor

swift-ci commented Mar 5, 2020

Build failed
Swift Test Linux Platform
Git Sha - 190b8a7

@spevans
Copy link
Contributor

spevans commented Mar 6, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - 190b8a7

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - 190b8a7

@milseman milseman merged commit 4715d68 into swiftlang:master Mar 9, 2020
@valeriyvan valeriyvan deleted the RemoveRedundantZeroingStringGuts branch February 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valeriyvan @milseman @swift-ci @spevans