Skip to content

[stdlib] Disable assertion tripping up ASAN #30260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

milseman
Copy link
Member

@milseman milseman commented Mar 6, 2020

We have (and important!) assertion that our claimed allocation is
complete and the breadcrumbs are falling where we expect them
to. Something about ASAN changes the allocation behavior. Temporarily
disable this assertion until I can figure how to work with ASAN here.

rdar://problem/60126935

https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/4436/consoleText

We have (and important!) assertion that our claimed allocation is
complete and the breadcrumbs are falling where we expect them
to. Something about ASAN changes the allocation behavior. Temporarily
disable this assertion until I can figure how to work with ASAN here.
@milseman milseman requested a review from rintaro March 6, 2020 16:44
@milseman
Copy link
Member Author

milseman commented Mar 6, 2020

@swift-ci please smoke test

@rintaro
Copy link
Member

rintaro commented Mar 6, 2020

Merging to unblock ASAN bots

@rintaro rintaro merged commit 3f69d6b into swiftlang:master Mar 6, 2020
@milseman milseman deleted the assert_san branch March 6, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants